Skip to content

Commit

Permalink
MemoryExec INSERT INTO refactor to use ExecutionPlan (apache#6049)
Browse files Browse the repository at this point in the history
* MemoryExec insert into refactor

* Merge leftovers

* Set target partition

* Comment and formatting improvements

* Comments on state.

* Letfover comments

* After merge corrections

* Correction after merge

---------

Co-authored-by: Mehmet Ozan Kabak <[email protected]>
  • Loading branch information
metesynnada and ozankabak authored Apr 28, 2023
1 parent 191af8d commit d5a8c93
Show file tree
Hide file tree
Showing 5 changed files with 800 additions and 173 deletions.
4 changes: 2 additions & 2 deletions datafusion/core/src/datasource/datasource.rs
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,8 @@ pub trait TableProvider: Sync + Send {
async fn insert_into(
&self,
_state: &SessionState,
_input: &LogicalPlan,
) -> Result<()> {
_input: Arc<dyn ExecutionPlan>,
) -> Result<Arc<dyn ExecutionPlan>> {
let msg = "Insertion not implemented for this table".to_owned();
Err(DataFusionError::NotImplemented(msg))
}
Expand Down
Loading

0 comments on commit d5a8c93

Please sign in to comment.