sam ls: fixed command results when combine -d/-s/-f options #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if args.directories and itemType == sequenceParser.eTypeFolder: | ||
| toPrint = True | ||
| # sam-ls -f | ||
| if args.files and itemType == sequenceParser.eTypeFile: |
There was a problem hiding this comment.
No because we would like to combine these options.
For example:
sam ls -df
There was a problem hiding this comment.
Yes, but this is still true in this configuration.
It can only be true for one solution, as itemType has only one value.
There was a problem hiding this comment.
You are right: it is working because itemType has only one value.
I overwrite the corresponding commit: f508ca9
added 2 commits
August 19, 2016 14:09
In a folder with directories and sequences:
* Before this commit:
* sam ls -d: only directories
* sam ls -s: only sequences
* sam ls -ds: nothing
* After this commit:
* sam ls -d: only directories
* sam ls -s: only sequences
* sam ls -ds: both directories and sequences
It is necessary to check that only if the item will be printed.
cchampet
force-pushed
the
fix_samLsFilterOptions
branch
from
d292666 to
27b6023
Compare
added 3 commits
August 29, 2016 09:47
… fix_samLsFilterOptions Conflicts: applications/sam/sam_ls.py
Instead, added a space in the details of each item.
* Instead, added a space. * Almost the same result when displaying, and easier to parse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.