sam rm: fixed command behavior when combine -d/-s/-f options + enabled '.' and '..' inputs #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 19, 2016 14:13
In a folder with directories and sequences:
* Before this commit:
* sam rm dirToRemove seqToRemove -d: only dirToRemove
* sam rm dirToRemove seqToRemove -s: only seqToRemove
* sam rm dirToRemove seqToRemove -ds: nothing
* After this commit:
* sam rm dirToRemove seqToRemove -d: only dirToRemove
* sam rm dirToRemove seqToRemove -s: only seqToRemove
* sam rm dirToRemove seqToRemove -ds: both dirToRemove and
seqToRemove
* Log the exception message in debug.
* Fix tuttleofx#570 * After this commit, we can use this kind of command to remove recursively all sequences in the working directory: sam rm . -Rs
In case of permission denied for example.
cchampet
force-pushed
the
fix_samRmCombineFilterOptions
branch
from
dfd200f to
805ca01
Compare
| try: | ||
| subFolder = os.path.join(item.getFolder(), item.getFilename()) | ||
| self.logger.debug('Browse in sub folder"' + subFolder + '" with the following filters: ' + str(filters)) | ||
| newItems = sequenceParser.browse(subFolder, detectionMethod, filters) |
There was a problem hiding this comment.
It seems that this is not recursive.
There was a problem hiding this comment.
Because of the potential exception?
There was a problem hiding this comment.
sequenceParser.browse browse the input folder but not recursively. And I don't see any code around to make the recursion.
There was a problem hiding this comment.
The instruction just below:
self._removeItems(newItems, args, detectionMethod, filters)There was a problem hiding this comment.
Oh yes, you're right! I didn't see that it's the same function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #570