wip #1
Open
wip #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a table has no rowUrl defined we currently redirect to root path. Which is not preferable. We should do nothing instead.
We do not want to render the whole layout if the request is a turbo frame request. We just want to render the component's html.
We don't want to deal with Turbo caching issues in the new admin. The content a customer agent or product administrator should always be the latest and most accurate version. Prefetching is a performance nightmare for an admin interface like ours. Co-authored-by: Eugene Chaikin <[email protected]>
This is actual links to open the new and edit forms in the modal dialog remotely.
That way we can disdplay the modal on an edit/new route but prevent the modal from being closed by the user.
In order to make redirects to the index route from an edit or new form and being able to re-display the form with errors in case of failed validation, we need to explicitely set the request format to html, otherwise turbo will refresh the edit/new page.
tvdeyen
force-pushed
the
open-modal-content-remotely
branch
9 times, most recently
from
16066fd to
0f2f8a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.