Skip to content
This repository has been archived by the owner on Feb 1, 2022. It is now read-only.

Travis: Drop custom caching and switch to node.js 8. #363

Merged
merged 2 commits into from
Aug 9, 2017
Merged

Conversation

XhmikosR
Copy link
Member

Fixes #310

@XhmikosR XhmikosR added this to the v1.0.0 milestone Mar 14, 2016
@XhmikosR
Copy link
Member Author

@cvrebert: it appears coveralls fails, not due to this patch, though.

And the build isn't marked as failed, not sure if that's intentional.

@XhmikosR
Copy link
Member Author

Looking into the coveralls issue, it seems it's due to fishbar/jscoverage#35

The potential fix might be something as simple as

require("coffee-script/register")

Should we fork jscoverage or look for alternatives?

So this leaves us the build being marked as successful.

@cvrebert
Copy link
Collaborator

Should we fork jscoverage or look for alternatives?

I would warmly welcome a patch to switch to Istanbul. I'm open to proposals for other alternative tools too.
But it seems like the easiest fix would be to just add a devdependency on coffeescript and stick with jscoverage, so I'd also accept a patch for that.

@@ -0,0 +1,39 @@
GEM
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we just refer to the Gemfiles from our git clone of Bootstrap?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That I don't know,

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should just be a matter of moving the clone into the install steps and adding a couple cp commands after the clone.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be doable, yes. Feel free to push here if you want.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, added to my todo list

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might give it a go if I have time too, but I can't promise anything.

@XhmikosR
Copy link
Member Author

But it seems like the easiest fix would be to just add a devdependency on coffeescript and stick with jscoverage, so I'd also accept a patch for that.

Nope, I tried that but still fails.

@cvrebert
Copy link
Collaborator

not due to this patch, though.

Ah. Then open a new issue and we'll ignore the failure for now.

@XhmikosR
Copy link
Member Author

XhmikosR commented Aug 9, 2017

@Johann-S: I totally forgot I had made this. I'll test it out.

@XhmikosR XhmikosR force-pushed the travis-cache branch 3 times, most recently from 766b339 to bfdeecd Compare August 9, 2017 09:41
@XhmikosR XhmikosR changed the title Travis: Drop custom caching. Travis: Drop custom caching and switch to node.js 8. Aug 9, 2017
@XhmikosR XhmikosR merged commit a9506ce into master Aug 9, 2017
@XhmikosR XhmikosR deleted the travis-cache branch August 9, 2017 09:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants