-
-
Notifications
You must be signed in to change notification settings - Fork 311
Travis: Drop custom caching and switch to node.js 8. #363
Conversation
@cvrebert: it appears coveralls fails, not due to this patch, though. And the build isn't marked as failed, not sure if that's intentional. |
Looking into the coveralls issue, it seems it's due to fishbar/jscoverage#35 The potential fix might be something as simple as require("coffee-script/register") Should we fork jscoverage or look for alternatives? So this leaves us the build being marked as successful. |
I would warmly welcome a patch to switch to Istanbul. I'm open to proposals for other alternative tools too. |
@@ -0,0 +1,39 @@ | |||
GEM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we just refer to the Gemfiles from our git clone of Bootstrap?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That I don't know,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should just be a matter of moving the clone
into the install
steps and adding a couple cp
commands after the clone
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be doable, yes. Feel free to push here if you want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, added to my todo list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might give it a go if I have time too, but I can't promise anything.
Nope, I tried that but still fails. |
Ah. Then open a new issue and we'll ignore the failure for now. |
@Johann-S: I totally forgot I had made this. I'll test it out. |
766b339
to
bfdeecd
Compare
Fixes #310