Change selector-engine.js parents method to utilize better js nativ…

…e methods (#35684) Co-authored-by: XhmikosR <[email protected]>
twbs · Jan 30, 2022 · 882185b · 882185b
1 parent 89f8876
commit 882185b
Showing 1 changed file with 4 additions and 9 deletions.
diff --git a/js/src/dom/selector-engine.js b/js/src/dom/selector-engine.js
@@ -11,8 +11,6 @@ import { isDisabled, isVisible } from '../util/index'
  * Constants
  */
 
-const NODE_TEXT = 3
-
 const SelectorEngine = {
   find(selector, element = document.documentElement) {
     return [].concat(...Element.prototype.querySelectorAll.call(element, selector))
@@ -28,14 +26,11 @@ const SelectorEngine = {
 
   parents(element, selector) {
     const parents = []
-    let ancestor = element.parentNode
-
-    while (ancestor && ancestor.nodeType === Node.ELEMENT_NODE && ancestor.nodeType !== NODE_TEXT) {
-      if (ancestor.matches(selector)) {
-        parents.push(ancestor)
-      }
+    let ancestor = element.parentNode.closest(selector)
 
-      ancestor = ancestor.parentNode
+    while (ancestor) {
+      parents.push(ancestor)
+      ancestor = ancestor.parentNode.closest(selector)
     }
 
     return parents