Accept argument of different types in the getInstance method (#34333)

twbs · Jun 29, 2021 · d314466 · d314466
1 parent b00355d
commit d314466
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/js/src/base-component.js b/js/src/base-component.js
@@ -48,7 +48,7 @@ class BaseComponent {
   /** Static */
 
   static getInstance(element) {
-    return Data.get(element, this.DATA_KEY)
+    return Data.get(getElement(element), this.DATA_KEY)
   }
 
   static getOrCreateInstance(element, config = {}) {

diff --git a/js/tests/unit/base-component.spec.js b/js/tests/unit/base-component.spec.js
@@ -104,6 +104,20 @@ describe('Base Component', () => {
         expect(DummyClass.getInstance(element)).toBeInstanceOf(DummyClass)
       })
 
+      it('should accept element, either passed as a CSS selector, jQuery element, or DOM element', () => {
+        createInstance()
+
+        expect(DummyClass.getInstance('#foo')).toEqual(instance)
+        expect(DummyClass.getInstance(element)).toEqual(instance)
+
+        const fakejQueryObject = {
+          0: element,
+          jquery: 'foo'
+        }
+
+        expect(DummyClass.getInstance(fakejQueryObject)).toEqual(instance)
+      })
+
       it('should return null when there is no instance', () => {
         fixtureEl.innerHTML = '<div></div>'