Navbar toggle focus issues #12030
Comments
kevinawoo
added a commit
to Loopfirst/bootstrap
that referenced
this issue
Mar 28, 2014
* upstream/master: (119 commits) Drop trailling comma New Year fix assets links in all examples Update Gruntfile.js to copy 'dist/' files to 'docs/dist/' with 'grunt dist' task; Fixes twbs#12030: navbar toggle focus state Fix broken JS derp Fixes twbs#12046: move .csscomb.json and .csslintrc to less/ folder typo @nschonni's feedback <3 @cvrebert's feedback Update dependencies (again) Fixed typo Sauce now supports latest Firefox on OS X Mavericks default to latest Firefox version on OS X fix capitalization of iOS mv sauce_browsers.yml out of the project root add note about ios dropdown compat fixes twbs#11379 - Fix carousel this.sliding not getting reset if $next.hasClass('active') fixes twbs#11373 - adds related target to dropdown events fixes twbs#11288 - Vertical scroll position of modal saves between openings ... Conflicts: Gruntfile.js dist/css/bootstrap-theme.css dist/css/bootstrap-theme.css.map dist/css/bootstrap-theme.min.css dist/css/bootstrap.css dist/css/bootstrap.css.map dist/css/bootstrap.min.css dist/js/bootstrap.js dist/js/bootstrap.min.js docs/assets/css/docs.css docs/assets/css/pygments-manni.css docs/assets/ico/apple-touch-icon-144-precomposed.png docs/assets/js/application.js docs/assets/js/customize.js docs/assets/js/customizer.js docs/assets/js/filesaver.js docs/assets/js/holder.js docs/assets/js/ie8-responsive-file-warning.js docs/assets/js/jszip.js docs/assets/js/less.js docs/assets/js/raw-files.js docs/assets/js/uglify.js test-infra/s3_cache.py
stempler
pushed a commit
to stempler/bootstrap
that referenced
this issue
Apr 11, 2014
… 'grunt dist' task; Fixes twbs#12030: navbar toggle focus state
stempler
pushed a commit
to stempler/bootstrap
that referenced
this issue
Nov 4, 2014
… 'grunt dist' task; Fixes twbs#12030: navbar toggle focus state
FlukeFan
added a commit
to FlukeFan/LucidDotNet
that referenced
this issue
Nov 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've encountered one or two small bugs with toggling the navigation menu that I wanted to share.
The first appears to definitely be a bug. When the menu button is clicked, the background color changes as the button takes focus, but when it is clicked again to collapse the menu, the background color stays the same. In Firefox and Chrome, clicking anywhere on the page takes focus away from the button and the button reverts back to its default background. In iOS, tapping elsewhere does not change focus and the menu button remains the focus until a new page is loaded. Maybe jQuery can be used to add an "active" class to the button when the menu is expanded.
The second issue is an aesthetic one. In Chrome, clicking the menu button creates an orange/yellow border around the button. This also does not revert when the menu is collapsed. Perhaps "outline: none;" should be added to the navbar-toggle class.
The text was updated successfully, but these errors were encountered: