Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

col-*-push-0 col-*-pull-0 #12854

Closed
Sojaner opened this issue Feb 26, 2014 · 4 comments
Closed

col-*-push-0 col-*-pull-0 #12854

Sojaner opened this issue Feb 26, 2014 · 4 comments
Labels
css
Milestone
v3.2.0

Comments

@Sojaner
Copy link
Contributor

Sojaner commented Feb 26, 2014

I see a wired situation in resting the pulls and pushes that is explained here:
http://stackoverflow.com/questions/22040210/bootstrap-layout-logically-correct-but-renders-weird/22041828#22041828
@cvrebert cvrebert added the css label Feb 26, 2014
@Sojaner
Copy link
Contributor Author

Sojaner commented Feb 26, 2014

I found the solution to the problem and fixed the code and will request the pull soon.

@Sojaner
Copy link
Contributor Author

Sojaner commented Feb 27, 2014

I committed the fix and set a pull request as #12863.

mdo added a commit that referenced this issue Mar 4, 2014
@mdo
Merge pull request #12863 from Sojaner/master
56c6525 
Fix for issue #12854 on push and pull resets
@mdo
Copy link
Member

mdo commented Mar 5, 2014

Fixed in #12863.

@mdo mdo closed this as completed Mar 5, 2014
@mdo mdo added this to the v3.2.0 milestone Mar 5, 2014
@Sojaner
Copy link
Contributor Author

Sojaner commented Mar 5, 2014

Thanks.

@mdo mdo mentioned this issue Mar 7, 2014
Closed
stempler pushed a commit to stempler/bootstrap that referenced this issue Nov 4, 2014
@Sojaner
(less) Fix for issue twbs#12854 where push and pull resets
8faa5ca 
The col-*-push-0 and col-*-pull-0 classes try to reset the positioning using 0% but this prevents the opposite direction positioning to freeze and not being set correctly.
To fix that, these must set the position to auto instead of 0% with means left:auto and right:auto instead of left:0% and right:0%.
stempler pushed a commit to stempler/bootstrap that referenced this issue Nov 4, 2014
@mdo
(less) Merge pull request twbs#12863 from Sojaner/master
9b074d1 
Fix for issue twbs#12854 on push and pull resets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css
Projects
None yet
Milestone
v3.2.0
Development

No branches or pull requests
3 participants
@mdo @cvrebert @Sojaner