Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel with tables doesn't resize properly #13202

Closed
dkarkar92 opened this issue Mar 27, 2014 · 10 comments
Closed

Panel with tables doesn't resize properly #13202

dkarkar92 opened this issue Mar 27, 2014 · 10 comments

Comments

@dkarkar92
Copy link

I have a panel with a table inside and the table has a few columns making it rather wide. If you view the panel table on a mobile device the table is wider than the panel making it look bad.

This only occurs on tables that are quite wide. I've tried using table-responsive and the issue still occurs. This occurs when the word is too long to \n to the next line. Simple fix would be to just make the panel width move with the table width.

Tested on Chrome and Firefox for Mac with the latest versions.

http://jsbin.com/bixetifi/1

Image:
panel-table issue

@cvrebert cvrebert added css and removed confirmed labels Mar 27, 2014
@cvrebert
Copy link
Collaborator

The div.table-responsive should be the parent of the table, not the whole panel: http://jsbin.com/jugoyige/2

@dkarkar92
Copy link
Author

Ok changed it on my pages, and it fixed the problem at mobile res, but it still occurs around 700-1000px. The table may not be ideal (3 long urls) but, it's still an issue.

http://jsbin.com/jugoyige/6/

@saas786
Copy link
Contributor

saas786 commented Mar 28, 2014

Hi @Enviii its not a core issue, for your project specific needs you can enable responsiveness for table for all devices, currently by default it applies responsiveness to only extra small devices (<768px).

Please refer to this
https://github.com/twbs/bootstrap/blob/master/less/tables.less#L165

and close the issue here.

@cvrebert
Copy link
Collaborator

This issue seems legitimate to me.

@alrick
Copy link

alrick commented Apr 3, 2014

+1
@saas786 Thanks for the tip pending the fix.

@mdo
Copy link
Member

mdo commented Apr 9, 2014

Yeah, I imagine we'll have to bump the breakpoint for where the responsive table kicks in from small to medium, which is rather high at around 900px. I'm torn on what to do here honestly.

@maxgronlund
Copy link

maybe text-overflow:ellipsis; and overflow:hidden could be used to fix my issue, with graphical elements it would'n

@cvrebert cvrebert added this to the v3.2.1 milestone May 22, 2014
@mdo
Copy link
Member

mdo commented Jun 19, 2014

Put the .table-responsive within the .panel: http://jsbin.com/bixetifi/2/edit.

@mdo mdo closed this as completed Jun 19, 2014
@mdo mdo removed this from the v3.2.1 milestone Jun 19, 2014
@alrick
Copy link

alrick commented Jul 16, 2014

Hi @mdo

Your solution isn't working on all cases, I've added some cols to your test table.
Check the jsbin, open the output in a single window and try to downsize, the content overflows the panel under ~ 1000px large.

Jsbin : http://jsbin.com/bixetifi/3/edit
Result : https://www.dropbox.com/s/o5epxuyc45odvxr/Screenshot%202014-07-16%2014.38.28.png

@cvrebert cvrebert reopened this Jul 16, 2014
@apexskier
Copy link
Contributor

Would adding overflow-x: auto to .table-responsive be an acceptable solution? It looks fine in my tests, but I'm haven't tested on windows.

Before:
without

After:
with

edit: To clarify, this is not within a media query, just the default action.

@mdo mdo added this to the v3.2.1 milestone Aug 2, 2014
@mdo mdo removed the help wanted label Aug 2, 2014
@mdo mdo closed this as completed in feed9ae Aug 2, 2014
@twbs twbs locked and limited conversation to collaborators Oct 30, 2014
stempler pushed a commit to stempler/bootstrap that referenced this issue Nov 4, 2014
…ive to prevent content breaking out of containers
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants