Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding aria-describedby="elementId" to tooltip plugin for better accessibility #13480

Closed
bassettsj opened this issue May 1, 2014 · 3 comments

Comments

@bassettsj
Copy link
Contributor

Adding a bit of info to the item with aria-describedby to the tooltip/popover would help signal to Assistive Technology, like screen readers, that element getting targeted by the tooltip/popover that it is better described by this other DOM thing. This is illustrated on paypal/bootstrap-accessibility-plugin source line 32

Changes that would need to happen:

  • Create an unique ID / or use for the target element on show
  • Add an aria-describedby="elementId" on the element on show

We already have role="tooltip" 👍

@bassettsj
Copy link
Contributor Author

@cvrebert I made an attempt at authoring a few tests and changes to the tooltip plugin for bootstrap.

I wanted to see if I could open a pull request for this issue, I am trying to follow the CONTRIBUTING guidelines, but still my first PR here. My branch is on topic branch of the fork. Would it help to open a PR now?

@cvrebert
Copy link
Collaborator

cvrebert commented May 9, 2014

@bassettsj Go for it.

bassettsj added a commit to bassettsj/bootstrap that referenced this issue May 9, 2014
resolves issue twbs#13480

- set up test
- linted the code styles
- passed the tests
- integrated feedback from @cvrebert
bassettsj added a commit to bassettsj/bootstrap that referenced this issue May 16, 2014
Generates a unique id for tooltip and adds [aria-describedby] to the element
it is called on. Resolves issue twbs#13480

- set up test
- linted the code styles
- passed the tests
- integrated feedback from @cvrebert
@cvrebert
Copy link
Collaborator

Fixed by #13557.

cvrebert added a commit that referenced this issue May 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants