Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus outlines not working #13914

Closed
hnrch02 opened this issue Jun 24, 2014 · 12 comments
Closed

Focus outlines not working #13914

hnrch02 opened this issue Jun 24, 2014 · 12 comments

Comments

@hnrch02
Copy link
Collaborator

hnrch02 commented Jun 24, 2014

If you tab to the checkbox in this Bin, you will see that focus outlines are not working.
Only the minified CSS is affected, so I traced the problem back to clean-css.

If I give clean-css this

div {
  outline: 5px auto -webkit-focus-ring-color;
}

it gives me back this

div{outline:-webkit-focus-ring-color 5px}

removing auto from the property and rendering focus outlines (at least in WebKit) non-existent.

/cc @mdo @cvrebert @XhmikosR

@hnrch02
Copy link
Collaborator Author

hnrch02 commented Jun 24, 2014

I'll file a upstream bug report with clean-css ASAP, just wanted to let you guys know, because that's kind of a blocker for 3.2.

@XhmikosR
Copy link
Member

Must be those recent changes in clean-css. @GoalSmashers is usually pretty fast in fixing issues.

@XhmikosR
Copy link
Member

Though, I do see the focus outline in your jsbin @hnrch02. What browser do you use?

@hnrch02
Copy link
Collaborator Author

hnrch02 commented Jun 24, 2014

As I said, Chrome, it is obviously only happening for WebKit.

@XhmikosR
Copy link
Member

Anyway, waiting for the upstream issue.

@hnrch02
Copy link
Collaborator Author

hnrch02 commented Jun 24, 2014

Filed just now.

@XhmikosR
Copy link
Member

Thanks.

@XhmikosR XhmikosR added this to the v3.2.0 milestone Jun 24, 2014
@XhmikosR
Copy link
Member

BTW, we can turn advanced optimizations off, until that's fixed.

@hnrch02
Copy link
Collaborator Author

hnrch02 commented Jun 24, 2014

Yeah, that fixes it.

hnrch02 added a commit to hnrch02/bootstrap that referenced this issue Jun 24, 2014
XhmikosR added a commit that referenced this issue Jun 24, 2014
Works around #13914.

We might give it another go in the future but the stuff this breaks over the time does not justify having it enabled. The gain in size is negligible:

dist/css/bootstrap.min.css: 108.65 kB → 109.5 kB
dist/css/bootstrap-theme.min.css: 18.84 kB → 18.86 kB
docs/assets/css/docs.min.css: 20.44 kB → 20.61 kB
@XhmikosR
Copy link
Member

I'm gonna move this to 3.2.1 or so since the issue is basically fixed, but I'd like to know when it's fixed upstream.

@XhmikosR XhmikosR modified the milestones: v3.2.1, v3.2.0 Jun 24, 2014
@cvrebert
Copy link
Collaborator

Thanks for being on top of this guys. <3

@hnrch02
Copy link
Collaborator Author

hnrch02 commented Jun 24, 2014

clean-css/clean-css#302 has been resolved.

@cvrebert cvrebert modified the milestones: v3.2.0, v3.2.1 Jun 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants