-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Focus outlines not working #13914
Comments
I'll file a upstream bug report with clean-css ASAP, just wanted to let you guys know, because that's kind of a blocker for 3.2. |
Must be those recent changes in clean-css. @GoalSmashers is usually pretty fast in fixing issues. |
Though, I do see the focus outline in your jsbin @hnrch02. What browser do you use? |
As I said, Chrome, it is obviously only happening for WebKit. |
Anyway, waiting for the upstream issue. |
Filed just now. |
Thanks. |
BTW, we can turn advanced optimizations off, until that's fixed. |
Yeah, that fixes it. |
Until clean-css/clean-css#302 is resolved. Refs twbs#13914
Works around #13914. We might give it another go in the future but the stuff this breaks over the time does not justify having it enabled. The gain in size is negligible: dist/css/bootstrap.min.css: 108.65 kB → 109.5 kB dist/css/bootstrap-theme.min.css: 18.84 kB → 18.86 kB docs/assets/css/docs.min.css: 20.44 kB → 20.61 kB
I'm gonna move this to 3.2.1 or so since the issue is basically fixed, but I'd like to know when it's fixed upstream. |
Thanks for being on top of this guys. <3 |
clean-css/clean-css#302 has been resolved. |
If you tab to the checkbox in this Bin, you will see that focus outlines are not working.
Only the minified CSS is affected, so I traced the problem back to clean-css.
If I give clean-css this
it gives me back this
removing
auto
from the property and rendering focus outlines (at least in WebKit) non-existent./cc @mdo @cvrebert @XhmikosR
The text was updated successfully, but these errors were encountered: