Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockquote in list has ugly top 'padding' due to poor clearfix #14682

Closed
Daniel-Hug opened this issue Sep 24, 2014 · 1 comment
Closed

blockquote in list has ugly top 'padding' due to poor clearfix #14682

Daniel-Hug opened this issue Sep 24, 2014 · 1 comment
Assignees
Labels
Milestone

Comments

@Daniel-Hug
Copy link

Take a look at this demo:

http://jsbin.com/hawabi/1/edit?html,output

See that ugly spacing above the text in the blockquote? That's because its clearfix is done poorly:

// Quotes
blockquote:before,
blockquote:after {
  content: "";
}

It's missing the essential display: table; that is seen in Nicolas Gallagher's micro clearfix hack.

From that link:

The use of table rather than block is only necessary if using :before to contain the top-margins of child elements.

@mdo
Copy link
Member

mdo commented Sep 24, 2014

That's not a clearfix—it's to remove browser-set quotes around <blockquote> elements. I don't remember what browsers or OSes set that, but I'll check it out. Seems like it might be unnecessary.

@mdo mdo added this to the v3.2.1 milestone Sep 26, 2014
@mdo mdo self-assigned this Sep 26, 2014
@mdo mdo closed this as completed in 36fdd29 Sep 26, 2014
Saranya-Raaj pushed a commit to Saranya-Raaj/bootstrap that referenced this issue Oct 9, 2014
stempler pushed a commit to stempler/bootstrap that referenced this issue Nov 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants