Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: color utilities are not described in text utilities page #24809

Closed
ysds opened this issue Nov 17, 2017 · 5 comments
Closed

docs: color utilities are not described in text utilities page #24809

ysds opened this issue Nov 17, 2017 · 5 comments

Comments

@ysds
Copy link
Member

ysds commented Nov 17, 2017

At the http://getbootstrap.com/docs/4.0/content/typography/#text-utilities:

Text utilities
Change text alignment, transform, style, weight, and color with our text utilities.

However, the text utility page does not describe how to change color.

@exige81
Copy link
Contributor

exige81 commented Nov 17, 2017

Color utilities are covered in http://getbootstrap.com/docs/4.0/utilities/colors/

Personally, I feel like that is sufficient, but perhaps a link from the text-utilities page would be good?

@ysds
Copy link
Member Author

ysds commented Nov 17, 2017

Yes, my point is, it is not good navigation. It is better remove "color" or add link to the color utilities page.

@andresgalante
Copy link
Collaborator

Hi @ysds, I don't think we should remove colors since it's not only text color but also background colors.

@ysds
Copy link
Member Author

ysds commented Nov 21, 2017

@andresgalante and @mdo
I feel you didn’t fully understand what I meant, so please let me explain it try again.

When read the following sentence, I expect that the link target page includes how to change color.

image

But the page (text utilities) does not mention about color. The color utilites page explaines it.

I my opinion it would be better to remove the word 'color' from the sentence:

Change text alignment, transform, style, and weight with our text utilities.

or add link to color utilities page like:

Change text alignment, transform, style, weight, and color with our text utilities and color utilities.

@andresgalante
Copy link
Collaborator

@ysds you are right, thanks a lot for the clarification. I rather have the second option. Do you have time to send a PR? if not let me know and I'll fix it

@ysds ysds closed this as completed Nov 22, 2017
@ysds ysds reopened this Nov 22, 2017
ysds added a commit to ysds/bootstrap that referenced this issue Nov 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants