Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "Theming" documentation to include info on using CSS vars #25147

Closed
willthemoor opened this issue Dec 31, 2017 · 4 comments
Closed

Update "Theming" documentation to include info on using CSS vars #25147

willthemoor opened this issue Dec 31, 2017 · 4 comments
Assignees

Comments

@willthemoor
Copy link

Loving BS4. Needed to make a few tweaks to the default colors so I installed the SCSS via NPM, created my own _variables.scss doc, updated links, blah blah blah. All the while I'm thinking, "shouldn't BS4 use CSS vars for this?". Lo! I inspected an element for some other reason and saw a beautiful set of --vars on the :root element! 😃 🏕

I'm already invested in the custom SCSS route (and need to adjust a few other variables not accounted for in _root.scss) but I'm very glad to learn of this feature. If https://getbootstrap.com/docs/4.0/getting-started/theming/ had info on a) their availability and b) how to use them, I might have just sorted it all out with --vars and saved a bunch of time.

This is a really fantastic feature update to Bootstrap; this issue is me hoping it gets the documentation attention I reckon it deserves. TBH, my CSS Variables fu is weak (been hooked on pre-processors for so long) or I'd offer up a starter PR. Still, down to help get it going if someone wants to point my inner Energizer Bunny in the right direction.

@Herst
Copy link
Contributor

Herst commented Dec 31, 2017

I was about to open my own thread on the theming page, more specifically on how it would be neat if the page also gave some hints on tooling, for those people that don't just want to reverse-engineer package.json just so their custom build will be similar to bootstrap's.

@mdo mdo self-assigned this Jan 2, 2018
@mdo
Copy link
Member

mdo commented Jan 2, 2018

I can jump on this. Unsure about how much of the tooling I'll get into @Herst, but noted.

@mdo
Copy link
Member

mdo commented Jan 2, 2018

@Herst We have our build tools page by the way—perhaps we need to expand on things there? Can you open a separate issue with any additional thoughts/recommendations?

@gijsbotje
Copy link
Contributor

@Herst this article might help
https://medium.com/@gijsbotje/how-to-setup-a-bootstrap-project-like-bootstrap-does-it-3825a726b09a

@mdo mdo closed this as completed in #25176 Jan 3, 2018
mdo added a commit that referenced this issue Jan 3, 2018
* Add some documentation on using CSS vars

Fixes #25147

* link to MDN doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants