Use of .bg-white class in docs makes theming difficult in v5 - replace with .bg-body
#32810
Comments
|
@ErlendCat PR welcome 👌 Please read our contributing guidelines carefully before you start. |
|
Would love a |
|
@mdo ... it's already there. Gets generated in |
|
Hahaha, I'm the one that added it too lol. #29511 |
|
Created a pull request if you need one... #32815 |
|
PR #32815 generated |
|
Issue will close automatically as soon as the PR gets merged. |
mdo
pushed a commit
that referenced
this issue
Jan 25, 2021
Response to issue #32810 Use of the .bg-white class to define visual aspects of the examples would be unintuitive for theme builders to test themes on. This replaces instances of .bg-white with .bg-body in the examples. - Edited examples to replace use .bg-white class with .bg-body class - product - offcanvas - pricing - cheatsheet - cheatsheet-rtl - Edited utilities colors.md & shadows.md to include .bg-body class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A few of the example files make use of the
.bg-whiteclass to define visual aspects of the examples. Using this makes theming tests problematic without modification either to the docs source, or defining theme colors unintuitively (e.g..bg-whiteis black?)Use of directly calling color classes should be discouraged - i.e for the examples,
.bg-bodyshould be used instead.The following files make use of
.bg-white:site/content/docs/5.0/utilities/shadows.mdsite/content/docs/5.0/examples/product/index.htmlsite/content/docs/5.0/examples/offcanvas/index.htmlsite/content/docs/5.0/examples/cover/index.htmlsite/content/docs/5.0/examples/pricing/index.htmlsite/content/docs/5.0/examples/cheatsheet/index.htmlsite/content/docs/5.0/examples/cheatsheet-rtl/index.htmlAlso,
site/content/docs/5.0/utilities/colors.mdfile does not document the use of the.bg-bodyclass ... it's missing.The text was updated successfully, but these errors were encountered: