-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dl-horizontal float issue #3819
Labels
Comments
Ok, here is a possible better fix, borrowing part of what .clearfix does. The following could be added to .dl-horizontal:
So in less/type.less, that whole dl-horizontal definition would be:
That seems like it works. |
Associated pull request: #3821 |
Closing as dupe of #3821. |
stempler
pushed a commit
to stempler/bootstrap
that referenced
this issue
Apr 11, 2014
Instead of clearing the entire `.dl-horizontal`, we've moved the clearfix mixin to the `dd` level to solve two problems in one: empty `dd`s mid-list, and empty `dd` as the last child. Addresses a few old issues, including twbs#2824, twbs#3819, twbs#3821, twbs#4062, twbs#6707, and twbs#7180. Sorry that took so long :D.
stempler
pushed a commit
to stempler/bootstrap
that referenced
this issue
Nov 4, 2014
Instead of clearing the entire `.dl-horizontal`, we've moved the clearfix mixin to the `dd` level to solve two problems in one: empty `dd`s mid-list, and empty `dd` as the last child. Addresses a few old issues, including twbs#2824, twbs#3819, twbs#3821, twbs#4062, twbs#6707, and twbs#7180. Sorry that took so long :D.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When you have a definition list with dl-horizontal in a widescreen fluid layout, and have empty dd's towards the bottom, things under the dl with dl-horizontal move up (float issue) and looking at it in firebug appears that the dl is only is as tall as the last populated dd in the dl in FF 13.0 in OS X 10.7.4.
Currently working around with a hack under the dl:
The text was updated successfully, but these errors were encountered: