-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carousel - pausing while sliding (during transition) breaks the pause/resume control #5747
Comments
I'm playing with the carousel now and discovered this problem to.. from what I can see it only happens with you hover over the carousel while its in the middle of a slide, so before it gets done sliding.. it also happens on the example page - http://twitter.github.com/bootstrap/examples/carousel.html |
@Yohn, thanks for confirming. This problem is easy to reproduce by calling the next and pause methods right after each other: UPDATE if (this.$element.find('.next, .prev').length && $.support.transition.end) {
this.$element.trigger($.support.transition.end)
this.cycle()
} What's the logic in resuming cycle when it's just told to pause? |
Removing |
I also can see that the actual slide is removed if you hover in between a transition. This gives a not so nice flickering. if (this.$element.find('.next, .prev').length && $.support.transition.end) {
this.$element.trigger($.support.transition.end)
this.cycle()
} But i just wonder what's this piece of code for? :) |
@andreif you want to submit a pull request removing |
think this was resolved |
So, what should i change in the code? I am currently working on a bootstrap project I would like to fix it before i put the site on production. |
Pausing the carousel while sliding / during transition breaks the pause/resume control.
This happens when:
From this point on the carousel keeps cycling and there's no way stopping/pausing it anymore. Not on hover/mouseenter and not even with .carousel('pause').
Anyone else experiencing this problem, and maybe found a workaround?
http://jsfiddle.net/ANfXq/1/
The text was updated successfully, but these errors were encountered: