fixes carousel sliding issues

[Yohn]

Theres 2 slide fixes in the pull request..

First is when we click on the new indicators and stay hovered on the carousel it still cycles through the rest of the items, not pausing it as it should. to fix this, I added the , mouseover in the beginning of the plugin

The second refers to #5747 when the pausing feature stops working when you hover on the carousel while its in the middle of sliding. In that issue. @andreif pointed out that if we remove the this.cycle() from the pause function it works as expected..

I'm not sure how I would go about creating the tests for this, which is why I didnt include it.. is there a way to trigger the hover effect? I did update the carousel plugin on my local machine and ran the tests and it passed

[fat]

that mouseover fix doesn't make sense to me :/

can u add a unit test which reproduces this

[Yohn]

what was happening was when we clicked on the indicators and didnt mouseout of the carousel it wouldnt pause it, and mouseover stopped it from cycling through the slides

Ive been trying to come up with a way to do this with the tests but couldnt come up with the correct way yet.. heres what I was playing with..

      test("should not slide carsousel on mouseover", function () {
        var temp = $('<div id="myCarousel" class="carousel slide" data-interval="1000"> <ol class="carousel-indicators"><li data-target="#myCarousel" data-slide-to="0" class="active"></li><li data-target="#myCarousel" data-slide-to="1"></li><li data-target="#myCarousel" data-slide-to="2"></li>/ol><div class="carousel-inner"> <div class="item active"> <img alt=""> <div class="carousel-caption"> <h4>{{_i}}First Thumbnail label{{/i}}</h4> <p>Cras justo odio, dapibus ac facilisis in, egestas eget quam. Donec id elit non mi porta gravida at eget metus. Nullam id dolor id nibh ultricies vehicula ut id elit.</p> </div> </div> <div class="item"> <img alt=""> <div class="carousel-caption"> <h4>{{_i}}Second Thumbnail label{{/i}}</h4> <p>Cras justo odio, dapibus ac facilisis in, egestas eget quam. Donec id elit non mi porta gravida at eget metus. Nullam id dolor id nibh ultricies vehicula ut id elit.</p> </div> </div> <div class="item"> <img alt=""> <div class="carousel-caption"> <h4>{{_i}}Third Thumbnail label{{/i}}</h4> <p>Cras justo odio, dapibus ac facilisis in, egestas eget quam. Donec id elit non mi porta gravida at eget metus. Nullam id dolor id nibh ultricies vehicula ut id elit.</p> </div> </div> </div> <a class="left carousel-control" href="#myCarousel" data-slide="prev">&lsaquo;</a> <a class="right carousel-control" href="#myCarousel" data-slide="next">&rsaquo;</a> </div>')
        temp.appendTo("body");
        $.support.transition =  false
        stop()

        $('.carousel-indicators [data-slide-to="1"]').click()
        temp.trigger('mouseover')

        temp.on('slide', function(){
            alert('slid')
            ok(true, 'carousel slid once')
            $('.carousel').on('slide', function(){
                alert('slide again')
                ok(false, 'caroisel slid again')
            })
            start()
        })
      })

maybe someone can help me out with these tests?

[fat]

rather than listening to mouseover, i think it would be better to just check if the carousel is paused before calling cycle

[fat]

hm that seems to be fixed… 

the carousel shouldn't transition when you're hovering the arrows – and doesn't currently in 2.3 (at least i can't reproduce)

thanks man