Bower: Ignore development and documentation files on bower.json. Fix #10313 #10353
Conversation
…10313. I've kept only the files I consider relevant to bower installation: - Files in dist directory; - Files in js directory; - Files in less directory; - bower.json file; - README.md file; - LICENSE file.
| "_*", | ||
| "assets", | ||
| "examples", | ||
| "/fonts", |
There was a problem hiding this comment.
Why does only this entry have a leading slash?
|
It's because it should match only the top fonts directory, and not the fonts directory inside dist. |
|
This is still an active issue btw. Looks like it's just cloning the whole repo instead of just the relevant parts. |
|
@cvrebert Any chances that this PR be merged on master? |
| "**/.*" | ||
| "**/.*", | ||
| "_*", | ||
| "assets", |
There was a problem hiding this comment.
This should now be docs-assets.
There was a problem hiding this comment.
I'll revise and made this modification.
|
I'm not personally going to be the one to merge it since I'm not a Bower expert. |
|
👍 This one is still an important step. Getting the project through bower leads to polluting files... |
|
@Ninir +1 |
Bower: Ignore development and documentation files on bower.json. Fix #10313
|
Oh, whatever. Looks sensible. |
|
THanks @cvrebert, you're the man :) 👍 |
|
Damned, I just see this point after the new 3.0.3 is released... Hi guys, I'm installing bootstrap via bower, through grunt (with grunt-bower-task). Then, post install actions are run via grunt-bower-postinst. Concerning bootstrap, these actions are : running 'npm' command, override and copy some bootstrap .less files to customize the theme, and finally running 'grunt dist-css'. Now that config files are ignored when installing bootstrap (package.json, Gruntfile.js), it doesn't work anymore (with 3.0.3). I'm sure I can modify my process to compile bootstrap .less files in an other way, but it would be easier to re-use the task defined in bootstrap's Gruntfile. This way allows to use the original task configuration too. It seems odd that .less files are installed, but not the tools to compile them. I'm ok with the idea to not install documentation files (.html, ...), node_modules folder, etc. But what about config files ? Why should it not be installed ? The aim is not to install the component as in a production environment. Thank you in advance for your answers. |
|
ok, great, thank you. |
Fixes #10313.
I've kept only the files I consider relevant to bower installation: