-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firefox placeholder text is faded out and not the full color. #11526
Conversation
…g opacity:1 to it returns it to the proper color - (this is a re-commit since I messed up my branch last time and failed the travis build)
Testcase: http://jsfiddle.net/8b2d6/2/ |
Firefox placeholder text is faded out and not the full color.
<3 Thanks! |
Feels good man. |
X-Ref: necolas/normalize.css#246 |
Should this be added for firefox 4-18, too? I don't have 4-18 installed anywhere (nor am I really too worried people will be on FF4-18). Just seems like it'd make sense for consistency, though. |
I'm happy to test if I can wrangle up a version. I'll see what I can scour. |
More precise X-Ref: necolas/normalize.css#263 |
Now documented in MDN as part of bs-css-hacks: |
[skip sauce] [skip validator]
When using form-control-lg or form-control-sm some css properties of form-control are not respected as when using form-control: - placeholder style - disabled style I'm not sure if the form-control-ficus mixin may have been missing too... This would also require the addition to _form.scss in the mixins: ```scss @mixin form-control-states() { // Placeholder &::placeholder { color: $input-color-placeholder; // Override Firefox's unusual default opacity; see twbs#11526. opacity: 1; } // Disabled and read-only inputs // // HTML5 says that controls under a fieldset > legend:first-child won't be // disabled if the fieldset is disabled. Due to implementation difficulty, we // don't honor that edge case; we style them as disabled anyway. &:disabled, &[readonly] { background-color: $input-bg-disabled; // iOS fix for unreadable disabled content; see twbs#11655. opacity: 1; } } ```
> firefox 107.0 Firefox Release November 15, 2022
.form-control::placeholder {
color: #6c757d;
opacity: 1;
}
&::placeholder {
color: $input-placeholder-color;
// Override Firefox's unusual default opacity; see https://github.com/twbs/bootstrap/pull/11526.
// opacity: 1;
} &:disabled {
color: $input-disabled-color;
background-color: $input-disabled-bg;
border-color: $input-disabled-border-color;
// iOS fix for unreadable disabled content; see https://github.com/twbs/bootstrap/issues/11655.
opacity: 1;
} |
My previous pull request I did wrong as I didn't make a new branch (first time doing that). This should not fail the build and make everything work properly. Sorry.