Feature affix events #11664
Closed
Feature affix events #11664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Passed locally before but not on travis.
|
X-Ref: #11720 |
|
@sclarson Please add documentation for the new events. |
|
Also, one of your unit tests is currently failing on Travis. |
|
Yeah, I've been trying to find the travis problem on a separate branch. It On Thu, Dec 5, 2013 at 11:22 AM, Chris Rebert [email protected]:
|
|
Oh man, I'm super stoked to have this integrated... |
|
added events here: c77740b
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing my own issues from previous pull request #8113
This should now conform to the event guidelines. Please let me know if I made any other mistakes that need to be resolved.