Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move call for removeBackdrop() to backdrop() #11958

Closed

Conversation

tlindig
Copy link
Contributor

@tlindig tlindig commented Dec 20, 2013

function backdrop has a part, where the backdrop fade out is started. But the function removeBackdrop() was then called in 'hideModal'. That is not the optimal place for this.

It makes more difficult to extend to modal class, because it must be override more functions than it ought to be.

For instance I would like to implements a different handling for backdrop. With the change of this pull request, I only have to overwrite the backdorp function.

@cvrebert cvrebert modified the milestones: v3.2.0, v3.1.1 Feb 9, 2014
@fat
Copy link
Member

fat commented Mar 14, 2014

ah yeah i really like this change

@cvrebert
Copy link
Collaborator

cvrebert commented Apr 3, 2014

@fat So, are you okay with merging this for 3.2? (I'm happy to do the rebasing / conflict-resolution.)

@fat
Copy link
Member

fat commented Apr 20, 2014

@cvrebert yes please, thanks!

@cvrebert cvrebert closed this in a69bc3b Apr 20, 2014
@mdo mdo mentioned this pull request Apr 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants