move call for removeBackdrop() to backdrop() #11958
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
function
backdrop
has a part, where the backdrop fade out is started. But the functionremoveBackdrop()
was then called in 'hideModal'. That is not the optimal place for this.It makes more difficult to extend to
modal
class, because it must be override more functions than it ought to be.For instance I would like to implements a different handling for backdrop. With the change of this pull request, I only have to overwrite the
backdorp
function.