add note about printer viewport weirdness #12345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -528,6 +528,14 @@ <h3 id="support-fixed-position-keyboards">Modals, navbars, and virtual keyboards | |||
| <h3 id="support-browser-zooming">Browser zooming</h3> | |||
| <p>Page zooming inevitably presents rendering artifacts in some components, both in Bootstrap and the rest of the web. Depending on the issue, we may be able to fix it (search first and then open an issue if need be). However, we tend to ignore these as they often have no direct solution other than hacky workarounds.</p> | |||
|
|
|||
| <h3 id="support-printing">Printer viewports</h3> | |||
| <p>Even in some modern browsers, printing can be quirky. In particular, as of Chrome v32 and regardless of margin settings, Chrome uses a viewport width significantly narrower that the physical paper size when resolving media queries when printing a webpage. This can result in Bootstrap's extra-small grid being unexpectedly activated when printing. <a href="https://github.com/twbs/bootstrap/issues/12078">See #12078 for some details.</a> Suggested workarounds:</p> | |||
There was a problem hiding this comment.
"narrower that the physical paper size" -> "narrower than the physical paper size"
There was a problem hiding this comment.
I'd also suggest: "when resolving media queries when printing a webpage" -> "when resolving media queries while printing a webpage"
|
Looks fine to me apart from the typo I just pointed out. :) |
|
Thanks for the copyediting guys! |
|
Also, I didn't notice before, but look at what this PR's issue number is! |
mdo
added a commit
that referenced
this pull request
Jan 23, 2014
add note about printer viewport weirdness
|
💥 |
This was referenced Jan 23, 2014
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #12078.