Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #12845 - Modal#hide should only be called with an event argument #12850

Closed
wants to merge 1 commit into from

Conversation

hnrch02
Copy link
Collaborator

@hnrch02 hnrch02 commented Feb 26, 2014

P.S: Someone should run build-customizer-html, 7e551ec didn't regenerate that file.

@cvrebert cvrebert added the js label Feb 26, 2014
@cvrebert cvrebert added this to the v3.2.0 milestone Feb 26, 2014
@cvrebert
Copy link
Collaborator

Unit tests pass on Sauce: https://travis-ci.org/twbs/bootstrap/jobs/19626243

@zlatanvasovic
Copy link

👍

@fat
Copy link
Member

fat commented Mar 17, 2014

lgtm 👍

@cvrebert cvrebert closed this in 4e4e456 Mar 17, 2014
@mdo mdo mentioned this pull request Mar 17, 2014
@hnrch02 hnrch02 deleted the modal-toggle branch March 18, 2014 14:23
michaek pushed a commit to michaek/bootstrap that referenced this pull request May 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants