Clear scrollspy selection above first section #13563
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tadeuzagallo Could you please remove |
|
Oh, sorry... Just removed it! |
| return activeTarget != (i = targets[0]) && this.activate(i) | ||
| if (activeTarget && scrollTop < offsets[0]) { | ||
| this.activeTarget = null | ||
| return this.clear() |
There was a problem hiding this comment.
But clear() doesn't return anything...
There was a problem hiding this comment.
It was just to stop the script... Should I change it to
this.clear()
returnThere was a problem hiding this comment.
Ah, I see, this is Jacob being idiosyncratic in his style. Nevermind then. Leave as-is for the time being.
|
/cc @fat for review |
|
@tadeuzagallo Could you write a unit test for this to prevent future regression? |
Closed
|
Thanks for the work! I merged a modified version with a unit test. |
|
Oh, I'm sorry, I hadn't seen the comment regarding the tests... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once scrollspy had activated any item of the navbar it wouldn't clear it
anymore, leaving the first item activated for a scrolltop above the
first section.
I don't know if this was intended, but it has been bothering me in every project that I used ScrollSpy.