Document that alerts are removed from the DOM when closed; fixes #14318 #14332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm thinking it should be mentioned on line 26 too? |
|
How about this? |
| @@ -23,7 +23,7 @@ <h2 id="alerts-examples">Example alerts</h2> | |||
|
|
|||
| <h2 id="alerts-usage">Usage</h2> | |||
|
|
|||
| <p>Just add <code>data-dismiss="alert"</code> to your close button to automatically give an alert close functionality.</p> | |||
| <p>Just add <code>data-dismiss="alert"</code> to your close button to automatically give an alert close functionality. Closing an alert removes it from the DOM after all optional transitions are completed.</p> | |||
There was a problem hiding this comment.
@cvrebert are or have?
There was a problem hiding this comment.
"have", although I don't think you necessarily need to mention the transitions here.
cvrebert
added a commit
that referenced
this pull request
Aug 6, 2014
Document that alerts are removed from the DOM when closed; fixes #14318
|
Thanks as always! |
|
My pleasure. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #14318
@cvrebert Is this clear enough?