Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button: Fix checked prop on button's input not always applied correctly #14354

Closed
wants to merge 1 commit into from

Conversation

hnrch02
Copy link
Collaborator

@hnrch02 hnrch02 commented Aug 8, 2014

Fixes #14137

This fixes it properly rather than just reverting 4b40ee6.

Example: http://jsbin.com/kudav/1

BTW, the key to reproducing the problem mentioned in #14137 is to search for the point in the button where the cursor is in its default state and by that hovering over the invisible checkbox. Said checkbox can also be clicked and that's what is primarily causing these problems. This was introduced by #12794.

/cc @cvrebert @fat @Kolyunya @pixelchutes

@cvrebert cvrebert added the js label Aug 8, 2014
@cvrebert cvrebert added this to the v3.2.1 milestone Aug 8, 2014
@hnrch02
Copy link
Collaborator Author

hnrch02 commented Aug 9, 2014

This breaks the tests. We have three options:

  1. Rewrite the tests so that they work with delay this PR currently adds.
  2. Use a pure CSS fix for this by applying pointer-events: none; on the inputs, but this does only work for IE11+.
  3. Rewrite the button plugin to rely on the browser to update the checked property and toggle the .active class of the labels by listening for changes on the inputs. This only works with IE9+, as change has buggy behavior in IE8.

@cvrebert
Copy link
Collaborator

cvrebert commented Sep 7, 2014

Closing per #14137 (comment)

@cvrebert cvrebert closed this Sep 7, 2014
@hnrch02 hnrch02 deleted the fix-buttons-checked-prop branch September 7, 2014 20:18
@cvrebert cvrebert removed this from the v3.3.0 milestone Apr 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"checked" DOM property not always being effectively set
2 participants