Have Carousel ignore keyboard events from <input>s or <textarea>s #14993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
-1 per #14991 (comment). |
|
That's a fair point. I can see the merits of both sides and will be happy with whatever fat decides. |
|
If we ultimately reject this, then we should document more explicitly that forms aren't supported in Carousels. |
|
Good point. |
| @@ -42,6 +42,12 @@ | |||
| } | |||
|
|
|||
| Carousel.prototype.keydown = function (e) { | |||
| var tagName = e.target.tagName.toUpperCase() | |||
There was a problem hiding this comment.
i would maybe just change this to
if (/INPUT|TEXTAREA/.test(e.target.tagName)) return
|
If we are considering merging this, it would be much easier to do it like this: if ($(e.target).is('input, textarea')) return // or
if (/input|textarea/i.test(e.target.tagName)) return |
|
|
cvrebert
added a commit
that referenced
this pull request
Nov 5, 2014
Have Carousel ignore keyboard events from <input>s or <textarea>s
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14991.
/to @fat for review