Glyphicon accessibility tweaks #15009
Conversation
|
Looks fine to me. We can squash the |
|
LGTM too |
|
Damn, love it @patrickhlauke. Appreciate you doing all these accessibility improvements! <3 We need/want a squash, then we can merge yeah? |
|
@patrickhlauke: do you know how to do it yourself with |
|
urgh, clearly i don't. trying once more... |
|
@patrickhlauke: There's always Otherwise just CC me and I'll merge this manually later. |
- add aria-hidden="true" to avoid SRs unintentionally reading out the Unicode character (see http://www.filamentgroup.com/lab/bulletproof_icon_fonts.html) - callout with advice on accessible icon usage - replaced sr-only text in examples with (in the case of button) cleaner aria-label - additional example of icon used to convey meaning (in a non-interactive control)
|
i bloody hate git when it goes beyond the basics. right, think it's done (made the "stray |
|
Only 2 files changed in the rebased version? That doesn't seem right. |
|
It should be right...this PR was only a tiny intervention (fix the glyphicons documentation and apply the suggested best practice to the only other place I found that needed it, the about page) |
|
Ah, right; had this confused with your other, larger open PR. |
|
Thanks for the contribution! Keep the accessibility tweaks coming. |
…tweaks Glyphicon accessibility tweaks
No description provided.