avoid unnecessary HTML string building+parsing #16024
Merged
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't find any references that this is faster. Do you have any numbers? Also, are these the only cases? The idea seems fine to me, just wondering. |
Yes: http://jsperf.com/dom-constr-42
Yes, except for the unit tests. |
|
Wow, huge difference! Definitely How did you spot this? |
.
|
I was reminded about it when nitpicking an instance of it in some new unit tests in a PR the other day. |
cvrebert
added a commit
that referenced
this pull request
Mar 19, 2015
avoid unnecessary HTML string building+parsing
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than building a string of HTML and then parsing it, which is overkill and comparatively slow, this simply creates a new blank
<div>and then adds the requisite classes via jQuery.This could be further tweaked to use
classNameinstead of jQuery'saddClassat the cost of a bit more verbosity; I opted to be conservative.