Hide the Copy buttons in docs when Flash is not available

[tarebyte]

From issue #16269.

Feedback welcome!

[cvrebert]

Could you remove the ZeroClipboard.min.map file?

[cvrebert]

Please fix the JS coding style errors that are making the Travis build fail (see the Travis log for details).

[cvrebert]

So, when Flash is unavailable, the first time the user presses a Copy button, all the Copy buttons will disappear?

[tarebyte]

@cvrebert the user never sees the copy button if flash is not supported

[cvrebert]

Great, was just making sure since I'm not too familiar with ZeroClipboard.

[tarebyte]

@cvrebert is there a way to optimize the JS so that you can't see the button appear and then dissapear?

This is what I run into sometimes.

[cvrebert]

@tarebyte Not that I know of.

[cvrebert]

Just tested this out; LGTM.

[tarebyte]

💖

[cvrebert]

Thanks for this improvement! <3

[XhmikosR]

@tarebyte @cvrebert: there was a reason we sticked to that older version. And that is that the newer versions do not work with IE < 9.

[XhmikosR]

Personally, I'd appreciate a CC before this kind of stuff.

[cvrebert]

Sorry about the CC; didn't know you were interested.

And that is that the newer versions do not work with IE < 9.

In retrospect, we should have documented that better...

[XhmikosR]

Well... I don't see where one could document this. IE 8 support was there,
and I purposely skipped updating this. You should find more info maybe in
the PR that introduce ZeroClipboard.

Will you do the revert or do you want me to make a PR?
On Apr 28, 2015 1:08 PM, "Chris Rebert" [email protected] wrote:

Sorry about the CC; didn't know you were interested.

And that is that the newer versions do not work with IE < 9.

In retrospect, we should have documented that better...

—
Reply to this email directly or view it on GitHub
#16301 (comment).

[cvrebert]

PR would be faster, since this is low on my priority list.