-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hide captions for for smaller viewports #18258
Conversation
.btn { | ||
text-shadow: none; // No shadow for button elements in carousel-caption | ||
@include media-breakpoint-up(sm) { | ||
display: block; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Properties should be ordered position, right, bottom, left, z-index, display, padding-top, padding-bottom, color, text-align, text-shadow
possibly also consider to apply Note it seems possible to do:
|
/cc @patrickhlauke |
Maybe I'm missing something here, but: if captions convey information, why should they be hidden, ever? Turning them into screen-reader only text on small screen size will, paradoxically, make the information accessible to screen-reader users while not making it accessible to any other user group. Why? Are non-AT-users not supposed to get the info? |
There is a general problem with the caption text getting cut off if there's insufficient room for it. However, this isn't particular to XS screens per se, so I agree that this PR's hiding scheme isn't a great solution. @mdo Could you give your reasoning for #18171 (comment) ? |
Well non-AT-users can see the images of the carousel. But indeed i agree this make only sense when the information is only addtional to the images. |
My thought there was just how crazy they look with the captions overlaying things. Looking at the screenshots again, it'd be nice if the captions simply moved to the bottom of the images instead. |
A workaround I've found is using CSS 3 |
This can be optionally handled with display utilities. Example coming with #21298. |
should close #18171