Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply word-wrap:break-word to Tooltips and Popovers #18927

Merged
merged 1 commit into from
Jan 24, 2016
Merged

Apply word-wrap:break-word to Tooltips and Popovers #18927

merged 1 commit into from
Jan 24, 2016
+5 −2

Conversation

cvrebert
Copy link
Collaborator

Fixes #16871 for v4.

@cvrebert cvrebert added this to the v4.0.0-alpha.3 milestone Jan 18, 2016
@cvrebert cvrebert mentioned this pull request Jan 18, 2016
Closed
mdo added a commit that referenced this pull request Jan 24, 2016
@mdo
Merge pull request #18927 from twbs/fix-16871
2fe6c6c 
Apply word-wrap:break-word to Tooltips and Popovers
@mdo mdo merged commit 2fe6c6c into v4-dev Jan 24, 2016
@mdo mdo mentioned this pull request Jan 24, 2016
Closed
@IdanCo
Copy link
Contributor

IdanCo commented Apr 4, 2016

@mdo , @cvrebert , you mentioned We deliberately do NOT reset font-size or word-wrap.

why not reset word-wrap? this issue repeats itself in titles, in paragraphs. why not implement a wider solution?

@IdanCo IdanCo mentioned this pull request Apr 4, 2016
Closed
@cvrebert cvrebert deleted the fix-16871 branch July 18, 2016 02:42
@cvrebert
Copy link
Collaborator Author

@IdanCo Basically, I wasn't sure that setting word-wrap: break-word; more widely would be safe, particularly with regard to third-party libraries.
Although looking around now, dobtco/dvl-core#186 suggests it might actually be viable...

@cvrebert cvrebert mentioned this pull request Jul 18, 2016
Closed
@cvrebert
Copy link
Collaborator Author

@IdanCo Filed #20323 to look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
css v4
Projects
None yet
Milestone
v4.0.0-alpha.3
Development

Successfully merging this pull request may close these issues.
3 participants
@cvrebert @IdanCo @mdo