Image replacement needs more documentation and examples (#22613) #22811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdo
reviewed
Jun 13, 2017
| @@ -18,3 +18,18 @@ Utilize the `.text-hide` class or mixin to help replace an element's text conten | |||
| @include text-hide; | |||
| } | |||
| {% endhighlight %} | |||
|
|
|||
| The `.text-hide` class is useful for when you want the benefits heading tags like accessibility and SEO, but want to utilize your brand's logo image instead of text. | |||
There was a problem hiding this comment.
Small edit for this:
Use the `.text-hide` class to maintain the accessibility and SEO benefits of heading tags, but want to utilize a `background-image` instead of text.
| .logo { | ||
| background-image: url('/assets/brand/bootstrap-solid.svg'); | ||
| } | ||
| {% endhighlight %} |
There was a problem hiding this comment.
I'd pick one example here, not a mix of these two as it could confuse beginners. Delete L27-34 maybe?
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an extra description on why you would utilize the
.text-hideclass along with an example.Fixes #22613