Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Bower support #23568

Merged
merged 4 commits into from
Sep 4, 2017
Merged

Drop Bower support #23568

merged 4 commits into from
Sep 4, 2017

Conversation

tkrotoff
Copy link
Contributor

@tkrotoff tkrotoff commented Aug 19, 2017

Bower is deprecated.

screen shot 2017-08-19 at 19 09 46

See bower/bower#2298

Dropping Bower will allow to split Bootstrap in multiple npm packages, see #23557 (comment) and following comments.

Ping @XhmikosR

@XhmikosR
Copy link
Member

@tkrotoff: maybe this solution would be better?

@mdo: please chime in; it is sort of a breaking change but Bower seems to be absolete nowadays, so it would be better if we provided a proper npm way to do things as we discussed in #23557

@mdo
Copy link
Member

mdo commented Aug 20, 2017

Asked Twitter to weigh in :D. I'm unsure on overall usage—I don't think Bower ever had install stats like npm does on their packages. Hard to know how used it is.

@jerguslejko
Copy link

I vote: "drop it".

@rowdyrabouw
Copy link

Drop it vote!

@auvipy
Copy link

auvipy commented Aug 20, 2017

drop it

@witchscrow
Copy link

Drop it

@chyvak1831
Copy link

keep it

@dfosco
Copy link

dfosco commented Aug 20, 2017

If it means Bootstrap having multiple npm packages, I'm all in for dropping bower.

@witchscrow
Copy link

@chyvak1831 I feel like the argument for dropping is there. Do you have an argument for keeping it?

@Arseur
Copy link

Arseur commented Aug 20, 2017

I happen to use Bootstrap via Bower but would be happy to hear of a better way to proceed.

@dRagonsRage
Copy link

Keep it

@alexdreptu
Copy link

Drop it. There's no need for it to exist anymore. It's better for everyone to focus entirely on npm.

@igghera
Copy link

igghera commented Aug 20, 2017

Drop it

1 similar comment
@cto1
Copy link

cto1 commented Aug 20, 2017

Drop it

@cba85
Copy link

cba85 commented Aug 20, 2017

Drop it like it's hot

@ernitishkumar
Copy link

Dracarys

@matthew-inamdar
Copy link

Drop it

@cvrebert
Copy link
Collaborator

Drop it. It's been abandoned and practically superseded by npm for a while now.

@XhmikosR
Copy link
Member

So @mdo it seems most people are in favor of this. Only concern is VS?

@christopherdarling
Copy link

Drop it

3 similar comments
@mgwoolf
Copy link

mgwoolf commented Aug 20, 2017

Drop it

@jloosli
Copy link

jloosli commented Aug 20, 2017

Drop it

@UlisesCabrera
Copy link

Drop it

@dw-roth
Copy link

dw-roth commented Aug 20, 2017

drop

@blikblum
Copy link

Drop

@curtsheller
Copy link

Drop It!

@cvrebert
Copy link
Collaborator

cvrebert commented Aug 21, 2017

@tkrotoff That's just blatantly invalid JSON to make it clear that Bootlint deliberately doesn't support Bower. If there wasn't a bower.json, I'm sure we'd get pull requests adding one or issues asking for one.

@PhillipMwaniki
Copy link

Keep it.

@myplaneticket
Copy link

keep it

@kanhaic
Copy link

kanhaic commented Aug 21, 2017

Drop it npm is better.

@ph1p
Copy link

ph1p commented Aug 21, 2017

Drop it.

@kvz
Copy link

kvz commented Aug 21, 2017

There's so many fundamental issues with bower that, even if it causes breakage in cases, even for myself, I'd vote drop it. We'll fix those cases and move the whole ecosystem to brighter future with npm catering to all our packaging needs. If twbs sets this example I'm sure many will follow suit 👍❤️

@tkrotoff
Copy link
Contributor Author

tkrotoff commented Aug 21, 2017

@XhmikosR @cvrebert I've git rewrote history and kept bower.json with @$% Not a Bower package... ^&* in it.

@mhsnook
Copy link

mhsnook commented Aug 21, 2017

I vote drop.

Bower is kind of dead to me nowadays.

@xpose2000
Copy link

Keep. I still use bower.

@benmann
Copy link

benmann commented Aug 22, 2017

I'd decide based on the workload it creates to still support Bower. It's always nice to keep backwards compatibility, however if it involves some serious work on your end and is possibly blocking a more modular approach (which could likely be achieved with Bower as well?!) I'd say go with npm/yarn instead.

@tkrotoff
Copy link
Contributor Author

tkrotoff commented Aug 22, 2017

Bootstrap 3 will continue to be available with Bower. This only applies to v4. If you have an old project, this changes nothing.
If you create or upgrade a project to cutting edge Bootstrap 4, it does not make sense to rely on a deprecated tool for your project.

And Bower is deprecated, really:

  • Bower website displays the deprecation notice
  • same for the README:

screen shot 2017-08-21 at 12 12 17

  • and even when installing Bower:
$ npm install bower
npm WARN deprecated [email protected]: ..psst! While Bower is maintained,
we recommend Yarn and Webpack for *new* front-end projects!
Yarn's advantage is security and reliability,
and Webpack's is support for both CommonJS and AMD projects.
Currently there's no migration path,
but please help to create it: https://github.com/bower/bower/issues/2467

To all people who replied "Keep it", why?

@peternewnham
Copy link

Does dropping Bower also mean that all the compiled code in dist/ and js/dist/ can be removed and ignored from the repo or is there still a reason to include it?

@Johann-S
Copy link
Member

We use our dist files for our documentation too, so they'll stay if we drop Bower

@benmann
Copy link

benmann commented Aug 23, 2017

Bootstrap 3 will continue to be available with Bower. This only applies to v4. If you have an old project, this changes nothing.

As we're also advising people to use yarn/webpack for new projects, this sounds like a neat solution. 👯

@smilingpeanut
Copy link

I vote for keeping Bower support.

@JulianTenschert
Copy link

Please drop it.

@robertpetras
Copy link

Drop it.

@mdo mdo merged commit c770e68 into twbs:v4-dev Sep 4, 2017
This was referenced Sep 4, 2017
@tkrotoff tkrotoff deleted the drop-bower branch September 4, 2017 23:28
@twbs twbs locked and limited conversation to collaborators Sep 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.