Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structure examples with appropriate <main>, <header>, <footer> #23899

Merged
merged 3 commits into from
Sep 13, 2017
Merged

Structure examples with appropriate <main>, <header>, <footer> #23899

merged 3 commits into from
Sep 13, 2017

Conversation

patrickhlauke
Copy link
Member

Closes #23840

@patrickhlauke patrickhlauke requested a review from mdo September 10, 2017 12:29
XhmikosR
XhmikosR requested changes Sep 13, 2017
View reviewed changes
docs/4.0/examples/sticky-footer/index.html Outdated
@@ -19,13 +19,13 @@
<body>

<!-- Begin page content -->
<div class="container">
<main role="container" class="container">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vnu.jar in action, which is why we need to bring the HTML validator back. :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add the PR in the ship notes.

@patrickhlauke patrickhlauke merged commit d1b3c0c into twbs:v4-dev Sep 13, 2017
@mdo mdo mentioned this pull request Sep 13, 2017
Closed
@vanillajonathan
Copy link
Contributor

Consider also looking into the nav element.

@patrickhlauke
Copy link
Member Author

most examples seem to have it, but i wasn't looking for that specifically. good call, will be a follow-up pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XhmikosR XhmikosR XhmikosR approved these changes

@mdo mdo Awaiting requested review from mdo

Assignees
No one assigned
Labels
accessibility docs examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patrickhlauke @vanillajonathan @XhmikosR