Add bundlesize. #24145
Merged
Add bundlesize. #24145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, it seems bundlesize doesn't work on node.js 4 so we might want to bump the minimum version to 6 or run bundlesize only on node 8. |
|
Not against moving to node 6 plus node 4 maintenance will end in April 2018 |
XhmikosR
force-pushed
the
v4-dev-xmr-bundlesize
branch
from
0cf8699 to
b589815
Compare
|
Should I also add the CSS files? |
|
IMO @mdo would be interested to have our CSS file too |
XhmikosR
force-pushed
the
v4-dev-xmr-bundlesize
branch
3 times, most recently
from
32b44a0 to
be99749
Compare
bardiharborow
approved these changes
Oct 1, 2017
Also, be consistent with Node.js' name.
XhmikosR
force-pushed
the
v4-dev-xmr-bundlesize
branch
from
be99749 to
a976b3c
Compare
|
@mdo: will you add https://github.com/siddharthkp/bundlesize#2-build-status or should I merge now? |
Johann-S
approved these changes
Oct 1, 2017
|
Added env variable to Travis |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23009.
So, the sizes bundlesize reports are the gzip ones. I went with pretty strict values and separate entries, but we can always change them if needed.
Now, in order for the GitHub integration to work, @mdo needs to take care of https://github.com/siddharthkp/bundlesize#2-build-status