Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize examples' CSS. #24210

Merged
merged 2 commits into from
Oct 2, 2017
Merged

Normalize examples' CSS. #24210

merged 2 commits into from
Oct 2, 2017

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Oct 2, 2017

Ideally, I think we should use autoprefixer and also lint these to automate the process...

@mdo
Copy link
Member

mdo commented Oct 2, 2017

The examples have been a weird one to be honest. I've tried to keep them as isolated as possible, ensuring they run if you copy-paste, but that's kinda difficult. I'd prefer not to add a bunch of tooling to them though, but perhaps there's another approach I haven't considered.

@XhmikosR
Copy link
Member Author

XhmikosR commented Oct 2, 2017

We already use autoprefixer so it shouldn't be too hard to hook something up.

I'll make an issue to track this so that I won't forget.

@XhmikosR XhmikosR merged commit 2891dc1 into v4-dev Oct 2, 2017
@XhmikosR XhmikosR deleted the v4-dev-examples-normalize-css branch October 2, 2017 18:54
@mdo mdo mentioned this pull request Oct 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants