-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collapse overflow fix #2423
Collapse overflow fix #2423
Conversation
Thanks for pointing that out! The issue with |
…ollapse_overflow_fix
Manually handled this in 2.0.2-wip by making just the CSS change. Thanks! |
I should have probably have clarified this above: Without the javascript changes, the overflow problem is solved, but the collapsible animations does not behave correctly. The latest animations in the docs of a 2.0.2-wip build is broken. The content is shown before the width/height is animated. |
pelme is correct, it's still jacked up |
Temporary workaround:
When initializing collapse, pass in the following in the options hash:
|
…e why didn't get commited
After some research and experiments I found solution with following CSS selector: .collapse.in[style="height: auto;"] { It really looks like a hack, but amazingly works. |
thanks@mirasrael! |
@mirasrael also, fwiw, i had to ensure the start state was set properly. without the height:auto style set initially, then it won't work. This did the trick. |
Currently,
.collapse.in
specifiesoverflow: hidden
, probably to make the animations behave correctly.This causes problems when using drop-downs or other dynamic content that overflows the collapse area.
This can be seen in this jsfiddle:
http://jsfiddle.net/rdXfZ/1/
The commit simply uses overflow: visible for .collapse.in, and patches the show/hide in collapse() to properly set overflow.