-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples updates #24898
Merged
Merged
Examples updates #24898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4c9dfa6
to
b591959
Compare
b591959
to
85d74ec
Compare
@mdo: when you are ready, please squash any patches that can be squashed. |
- Adjust font-size and padding for pricing header and hero - Fix checkout's stacked column margins, plus update their check/radio markup - Update product's utilities to be responsive - Made blog cards somewhat responsive (needs a bit more work tbh)
…ly accomplished with new components in v4
ghost
reviewed
Jan 5, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jumbotron narrow? Oh dear, my most beloved example... 😟
Closed
Hello from the Chart.js team. Thanks for adding the example! |
@fulldecent Woohoo! Holler if there's anything else we can do to improve the page! <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bugs, updates to newer techniques, and adds some new examples. In addition, I've replaced the old
examples.md
file with anexamples.html
that loops over a new data file,examples.yml
, to generate our list of examples.Added four new examples—Pricing, Checkout, Product, and Floating Labels. Closes added pricing tables to the examples #18296.
Overhauled Dashboard with a brand new navbar and layout, large Chartjs example instead of placeholder circles, icons from Feather, and more.
Redesigned Offcanvas completely to be a mobile-focused example that integrates a drawer menu into the Bootstrap navbar.
Redesigned Blog to give it the appearance of popular blogging platforms and magazines, featuring horizontal cards, Google Web Fonts, and more.
Updated Sign-in to vertically center the form via flexbox and add more copy, images, and footer.
Refreshed Album to remove the bulk of the
.card
overrides, add more components to the albums, and improve the visual styles.Updated Cover to replace the table hack for vertical centering with flexbox, simplifying the HTML and CSS. Also fixed a bug where the nav would be left aligned on mobile devices.
Still have some more to do here, so leaving as WIP for v4 stable.
Closes #22847, takes a first pass implementation for #21312.