Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs-github-serve script for local serving the github target. #25139

Merged
merged 2 commits into from
Dec 30, 2017

Conversation

XhmikosR
Copy link
Member

This is mostly so that we can quickly test the github build without having to use other ways.

It assumes docs-github has been run, and it doesn't watch for changes.

@mdo
Copy link
Member

mdo commented Dec 30, 2017

This is mostly so that we can quickly test the github build without having to use other ways.

Is this referring to my ship checklist which mentions starting a Python server?

@XhmikosR
Copy link
Member Author

XhmikosR commented Dec 30, 2017 via email

@mdo
Copy link
Member

mdo commented Dec 30, 2017

Yeah, because of our plugins and what not, we can't do a straight git push origin gh-pages—we need to copy-pasta the code over. My build/ship script accomplishes this with a cp from bootstrap to a sibling clone of the repo, bs-docs. I switch over to that, run a Python server because there's only compiled files here, and verify some changes.

This wouldn't change that process for me though since the _config.yml and build/ aren't present in the gh-pages branch. I don't think I personally have a need for this one right now—is there another situation where this is required?

@XhmikosR
Copy link
Member Author

XhmikosR commented Dec 30, 2017 via email

@mdo mdo mentioned this pull request Dec 30, 2017
@XhmikosR XhmikosR merged commit 06d8e58 into v4-dev Dec 30, 2017
@XhmikosR XhmikosR deleted the v4-dev-xmr-docs-github-serve-script branch December 30, 2017 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants