Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove touch-action:manipulation click optimization #25250

Merged
merged 2 commits into from
Jan 11, 2018
Merged

Remove touch-action:manipulation click optimization #25250

merged 2 commits into from
Jan 11, 2018

Conversation

patrickhlauke
Copy link
Member

Due to a severe performance bug in Chrome (see https://bugs.chromium.org/p/chromium/issues/detail?id=800522) and due to the fact that (with the exception of IE/Edge on Windows desktop with touchscreen) all modern browsers now optimize the click delay away anyway, this optimization is not needed.

Closes #24670

Due to a severe performance bug in Chrome (see https://bugs.chromium.org/p/chromium/issues/detail?id=800522) and due to the fact that (with the exception of IE/Edge on Windows desktop with touchscreen) all modern browsers now optimize the click delay away anyway, this optimization is not needed.

Closes #24670
@XhmikosR
Copy link
Member

@mdo: you moved this into Ready to merge, but you didn't approve. Does it look good to you?

Personally, LGTM.

@patrickhlauke patrickhlauke merged commit 2e15b94 into twbs:v4-dev Jan 11, 2018
@mdo mdo mentioned this pull request Jan 11, 2018
@patrickhlauke patrickhlauke deleted the v4-dev-remove-touch-action branch June 2, 2018 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants