Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent print utils from overriding all other display utils #25269

Merged
merged 7 commits into from
Jan 18, 2018
Merged

Conversation

mdo
Copy link
Member

@mdo mdo commented Jan 11, 2018

Fixes #25221.

I agree with the referenced issue—this is unexpected and also causes a serious bug when mixed with other utility classes. This wasn't an issue in v3 given we had different utilities for hiding that weren't focused on the display property or a single direction for hiding content (mobile up).

This also adds support for all additional display values we have for the normal .d-* utilities.

  • Update documentation to mention all utilities
  • Entry to migration guide if needed

Fixes #25221.

I agree with the referenced issue—this is unexpected and also causes a serious bug when mixed with other utility classes. I don't know why this wasn't an issue in v3—perhaps folks weren't using these as widely? I'm planning on leaving this for a v4.x or v4.0.x release to get some feedback.
@mdo mdo merged commit 9b0fcbf into v4-dev Jan 18, 2018
@mdo mdo deleted the print-display branch January 18, 2018 01:29
@mdo mdo mentioned this pull request Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants