-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix date inputs heights in safari #30353
Fix date inputs heights in safari #30353
Conversation
@MartijnCuppens which iOS versions did you test? Line 10 in d79830c
|
Tangent, but saw the comment and figured I'd look up iOS distribution: https://developer.apple.com/support/app-store/. We can probably move to iOS 12+ given the browser share there. v4 covers us on older versions. |
@MartijnCuppens Could you create before and after test cases? |
Shouldn't this be also backported? |
Yes, made a separate PR since reboot changed a lot in v5 |
@MartijnCuppens Do you intend that this affect input style with Before: https://codepen.io/fellows3/pen/BaNmvvN |
a2e903c
to
62acca4
Compare
In that case we should only change the appearance for |
9828643
to
ccab761
Compare
It seems #11266 is solved in the meantime and this was causing the inputs to shrink (date & time inputs):
![image](https://user-images.githubusercontent.com/11559216/76101917-78eeb400-5fcf-11ea-9802-db459c8e1b85.png)