-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grid: checks for $grid-columns > 0
#30605
Conversation
4bfdf31
to
e997d83
Compare
We already have the |
841ad90
to
afef2ca
Compare
afef2ca
to
9535668
Compare
Yeah, and I favor the explicit option of |
Sorry @mdo, @MartijnCuppens and I, have some slack dm's on this subject and I forgot to log a follow up here. Here is a use case for a grid version, a minimal one: $enable-grid-classes: true; // option as is default So after this, our grid will look like: So no .col-* and .offset-*. This config, but with some $grid-breakpoints of course :) can be a valid choice if we don't need cols number and we just want equals one or auto. What do you think? I think that it's a small change for a big opportunity of improving css filesize when our users doesn't need the whole grid :) |
It's an edge case, but since it only adds a single |
Co-authored-by: Martijn Cuppens <[email protected]>
This PR adds:
$grid-columns: 0;
and removing all.col-[number]
when needed