Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5: Tweak some colors #31276

Merged
merged 5 commits into from
Jul 13, 2020
Merged

v5: Tweak some colors #31276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
53e6c5e
Tweak green and cyan colors, bump min contrast ratio to 4.5
mdo Jul 10, 2020
f2fb367
Merge branch 'main' into color-tweaks
patrickhlauke Jul 11, 2020
15d9bfd
Mention color changes in Migration guide
mdo Jul 13, 2020
0e2a26d
Update migration.md
XhmikosR Jul 13, 2020
720d7fe
Merge branch 'main' into color-tweaks
XhmikosR Jul 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions scss/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ $pink: #d63384 !default;
$red: #dc3545 !default;
$orange: #fd7e14 !default;
$yellow: #ffc107 !default;
$green: #28a745 !default;
$green: #198754 !default;
$teal: #20c997 !default;
$cyan: #17a2b8 !default;
$cyan: #0dcaf0 !default;

// scss-docs-start colors-map
$colors: (
Expand Down Expand Up @@ -87,10 +87,10 @@ $theme-color-interval: 8% !default;

// The contrast ratio to reach against white, to determine if color changes from "light" to "dark". Acceptable values for WCAG 2.0 are 3, 4.5 and 7.
// See https://www.w3.org/TR/WCAG20/#visual-audio-contrast-contrast
$min-contrast-ratio: 3 !default;
$min-contrast-ratio: 4.5 !default;

// Customize the light and dark text colors for use in our color contrast function.
$color-contrast-dark: $gray-900 !default;
$color-contrast-dark: $black !default;
$color-contrast-light: $white !default;

// fusv-disable
Expand Down
7 changes: 7 additions & 0 deletions site/content/docs/5.0/migration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,13 @@ toc: true
- Renamed `.sr-only` and `.sr-only-focusable` to `.visually-hidden` and `.visually-hidden-focusable`.
- Renamed `sr-only()` and `sr-only-focusable()` mixins to `visually-hidden()` and `visually-hidden-focusable()`.

### Colors

- Bumped color contrast ratio from 3:1 to 4.5:1.
- Set `$black` as color contrast color instead of `$gray-900`.
- Improved `$green` (and its theme alias `$success`) color to reach new minimum color contrast (moving from `#28a745` to `#198754`).
- Improved `$cyan` (and its theme alias `$info`) color to be more vibrant (moving from `#17a2b8` to `#0dcaf0`).

### Components

#### Buttons
Expand Down