Tooltip refactoring

[GeoSot]

some minor refactoring,plus a possible solution to focusIn glitch (as @XhmikosR pinpointed )

Preview : https://deploy-preview-32523--twbs-bootstrap.netlify.app/docs/5.0/components/tooltips/

[XhmikosR]

@GeoSot thank you very much for digging into this! That being said, can you please split the fix for #32372 to a separate PR?

While testing this patch I notice that indeed the #32372 issue is fixed, but there are cases the arrow momentarily shows up in the wrong direction:

[GeoSot]

I've reverted the possible fix and left the rest here

[rohit2sharma95]

This PR decreases the size of the un-minified file (-80B) and increases the size of the minified file (+28B).

[GeoSot]

@rohit2sharma95 I am glad, this request was approved. But can we ensure the 'this' scope thing? (maybe on another request)
We all know by theory, it has to be the same scope on arrow functions, but firefox debugger can be lying?

[rohit2sharma95]

True, wired behavior on firefox (Not getting the reference while hovering over this) 😄
But if you see the previous method in the call stack, you will find the context for this (in the dist file). Notice _this5 in the image below:

[XhmikosR]

So, basically, the only logic change is that in toggle() method, context didn't have the extra check:

-context = Data.getData(event.delegateTarget, dataKey)
+context = context || Data.getData(event.delegateTarget, dataKey)

I don't suppose this could cause any issues?

[XhmikosR]

@rohit2sharma95 any thoughts about #32523 (comment)?

[rohit2sharma95]

The second parameter is optional in _initializeOnDelegatedTarget method. So still the second expression (Data.getData(event.delegateTarget, dataKey)) is being used for the toggle method. LGTM 👍