Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs on enforcing HTTPS and avoiding mixed content #33017

Merged
merged 2 commits into from
Feb 9, 2021

Conversation

philipkiely
Copy link
Contributor

The live documentation requested that someone fill in the section on "Always use https"

This PR includes a short reference on why to use HTTPS for all sites.

It also includes a more relevant warning about mixed active content.

Both paragraphs link to authoritative, neutral third-party sources.

Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dig it! While it is outside the scope of the docs, maybe we can at least refer folks to Cloudflare or something as a starting point? Do they have a getting started guide we could link?

@philipkiely
Copy link
Contributor Author

Thanks @mdo! Regarding a getting started guide, the thing is the range of potential hosts is so large that there wasn't a getting started guide that I felt good about referring to with confidence that it would cover a meaningful subset of users. If they're using GitHub Pages or Netlify they have totally different needs than Wordpress and different than AWS and so on.

If anyone else has a reference they like I can link it but I think overall users will have to find their own for whatever host they're using, and that's ok!

This is my first PR with Bootstrap, what is the process of getting it merged now that it's approved?

@XhmikosR
Copy link
Member

XhmikosR commented Feb 9, 2021

I think further implementation details are outside of the scope of the guide. I mean, there are thousands of different services and software stacks.

I'd say we can merge this as is and expand it later.

@XhmikosR XhmikosR merged commit 96b86c1 into twbs:main Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants