Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add word-wrap and word-break to Reboot #33954

Closed
wants to merge 3 commits into from
Closed

Conversation

leafac
Copy link

@leafac leafac commented May 12, 2021

Why would you want the default browser behavior of a long word overflowing the container?

What’s already done:

What’s left to do:

  • Remove .text-break?
  • Provide an utility with the converse, which sets word-break and word-wrap back to normal?

Follow up to: #20323

Why would you want the default browser behavior of a long word overflowing the container?

What’s already done:

- Applied `.text-break` to `body` in Reboot (see https://getbootstrap.com/docs/5.0/utilities/text/#word-break)
- Removed instances of `word-wrap` from components, which now became redundant.

What’s left to do:

- Remove `.text-break`?
- Provide an utility with the converse, which sets `word-break` and `word-wrap` back to `normal`?

Follow up to: twbs#20323
@leafac leafac requested a review from a team as a code owner May 12, 2021 14:35
@alpadev alpadev added the css label May 12, 2021
@leafac
Copy link
Author

leafac commented May 17, 2021

@twbs/css-review

Please let me know if there’s anything I can do to help in the review. Also, I’d appreciate some direction on what to do with respect to the utilities, as mentioned in my original message.

Thank you 😀

@ffoodd
Copy link
Member

ffoodd commented May 17, 2021

Needs deep test for both our docs and examples to see if we're missing any side-effect. In my task list :)

@ffoodd
Copy link
Member

ffoodd commented Aug 31, 2021

Back to this, sorry for the delay. I noticed quite a few cases where it's not appropriate:

I tend to agree with the suggestion, however it'd clearly have major impacts and should be considered a breaking change. I think we'll pass on this one for v5, but might reconsider it for v6. @mdo any thougt?

@leafac
Copy link
Author

leafac commented Sep 13, 2021

Oh, good points. Thanks for looking into this. These things always have more ramifications than we’d expect. For your convenience, here are the issues that @ffoodd mentioned:

Screen Shot 2021-09-13 at 11 00 39

Screen Shot 2021-09-13 at 11 00 54

Screen Shot 2021-09-13 at 11 01 11

Leaving it for v6 sounds reasonable.

@mdo
Copy link
Member

mdo commented Dec 28, 2022

Closing as stale for now, can revisit in v6.

@mdo mdo closed this Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants